On Wed, Sep 9, 2020 at 11:09 PM Boris Kolpackov <boris@xxxxxxxxxxxxxxxxx> wrote: > > Masahiro Yamada <masahiroy@xxxxxxxxxx> writes: > > > Currently, get_relations_str() is declared before the struct gstr > > definition. > > Yes, I also ran into this while building the kconfig code with MSVC. > I just moved the struct gstr definition before lkc_proto.h #include > but your fix works just as well. > > Acked-by: Boris Kolpackov <boris@xxxxxxxxxxxxxxxxx> > > > > BTW, some are declared in lkc.h and some in lkc_proto.h, but the > > difference is unclear. I guess some refactoring is needed. > > Yes, please. My (potentially incorrect) understanding is that lkc_proto.h > was for functions that are not (or should not be) used by clients but > should nevertheless have prototypes due to -Wmissing-prototypes. I, > however, believe this no longer holds and so would vote to merge > lkc_proto.h into lkc.h. > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/boris.20200909155725%40codesynthesis.com. Applied to linux-kbuild/fixes. -- Best Regards Masahiro Yamada
