Masahiro Yamada <masahiroy@xxxxxxxxxx> writes: > Currently, get_relations_str() is declared before the struct gstr > definition. Yes, I also ran into this while building the kconfig code with MSVC. I just moved the struct gstr definition before lkc_proto.h #include but your fix works just as well. Acked-by: Boris Kolpackov <boris@xxxxxxxxxxxxxxxxx> > BTW, some are declared in lkc.h and some in lkc_proto.h, but the > difference is unclear. I guess some refactoring is needed. Yes, please. My (potentially incorrect) understanding is that lkc_proto.h was for functions that are not (or should not be) used by clients but should nevertheless have prototypes due to -Wmissing-prototypes. I, however, believe this no longer holds and so would vote to merge lkc_proto.h into lkc.h.
