On Wed, Jul 22, 2020 at 1:57 PM Joe Perches <joe@xxxxxxxxxxx> wrote: > > This -Wsign-compare compiler warning can be very noisy > and most of the suggested conversions are unnecessary. > > Make the warning W=3 so it's described under the > "can most likely be ignored" block. > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> > --- Applied to linux-kbuild. Thanks. > On Tue, 2020-07-21 at 14:32 -0700, Joe Perches wrote: > > On Tue, 2020-07-21 at 19:06 +0000, Corentin Labbe wrote: > > > This patch fixes the warning: > > > warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare] > > > > I think these do not really need conversion. > > Are these useful compiler warnings ? > > Perhaps move the warning from W=2 to W=3 so > it's described as "can most likely be ignored" > > scripts/Makefile.extrawarn | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn > index 62c275685b75..95e4cdb94fe9 100644 > --- a/scripts/Makefile.extrawarn > +++ b/scripts/Makefile.extrawarn > @@ -66,7 +66,6 @@ KBUILD_CFLAGS += -Wnested-externs > KBUILD_CFLAGS += -Wshadow > KBUILD_CFLAGS += $(call cc-option, -Wlogical-op) > KBUILD_CFLAGS += -Wmissing-field-initializers > -KBUILD_CFLAGS += -Wsign-compare > KBUILD_CFLAGS += -Wtype-limits > KBUILD_CFLAGS += $(call cc-option, -Wmaybe-uninitialized) > KBUILD_CFLAGS += $(call cc-option, -Wunused-macros) > @@ -87,6 +86,7 @@ KBUILD_CFLAGS += -Wpacked > KBUILD_CFLAGS += -Wpadded > KBUILD_CFLAGS += -Wpointer-arith > KBUILD_CFLAGS += -Wredundant-decls > +KBUILD_CFLAGS += -Wsign-compare > KBUILD_CFLAGS += -Wswitch-default > KBUILD_CFLAGS += $(call cc-option, -Wpacked-bitfield-compat) > > > -- Best Regards Masahiro Yamada
