On Mon, Jul 27, 2020 at 6:44 AM Wolfram Sang <wsa@xxxxxxxxxx> wrote:
>
> Mention why we open-code strsep, so it is clear that it is intentional.
>
> Fixes: 736bb11898ef ("modpost: remove use of non-standard strsep() in HOSTCC code")
Applied, but this Fixes tag looks questionable to me
because this patch is just adding a comment.
> Signed-off-by: Wolfram Sang <wsa@xxxxxxxxxx>
> ---
> scripts/mod/modpost.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 45f2ab2ec2d4..69341b36f271 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -144,6 +144,7 @@ char *get_line(char **stringp)
> if (!orig || *orig == '\0')
> return NULL;
>
> + /* don't use strsep here, it is not available everywhere */
> next = strchr(orig, '\n');
> if (next)
> *next++ = '\0';
> --
> 2.27.0
>
--
Best Regards
Masahiro Yamada
