On Wed, Apr 29, 2020 at 06:46:33PM +0100, Maciej W. Rozycki wrote: > On Mon, 27 Apr 2020, Nathan Chancellor wrote: > > > > Can you actually record in the change description what the difference in > > > the relevant link command is, as shown where `V=1' has been used with > > > `make' invocation? > > > > That will be rather unweildy to put in the commit message since > > currently, $(CC) + $(KBUILD_CFLAGS) is being used but I can if it is > > really desired. Otherwise, I can just put it where I put the changelog. > > Umm, is the difference so huge? I think a note along the lines of: > > "[...] This change adds/removes[*]: > > <part of the command affected> > > from the invocation of [...], which is required for [...]" > > -- only quoting what's actually changed will be sufficient. Reword as > required. Otherwise it's hard to guess now what the change actually does, > and it will be even harder for someone who comes across it and tries to > understand it the future, when the context might be hard to reproduce. > > [*] Delete as appropriate. > > Maciej I ended up figuring out a way to get the difference proper into the commit message in v4. Please take a look. Cheers, Nathan
