Hi Jessica, On Thu, Oct 3, 2019 at 3:57 AM Jessica Yu <jeyu@xxxxxxxxxx> wrote: > > +++ Matthias Maennich [27/09/19 14:41 +0100]: > >On Fri, Sep 27, 2019 at 06:35:56PM +0900, Masahiro Yamada wrote: > >> > >>I was hit by some problems caused by the module namespace feature > >>that was merged recently. At least, the breakage of > >>external module builds is a fatal one. I just took a look at the code > >>closer, and I noticed some more issues and improvements. > >> > >>I hope these patches are mostly OK. > >>The 4th patch might have room for argument since it is a trade-off > >>of "cleaner implermentation" vs "code size". > >> > >Thanks Masahiro for taking the time to improve the implementation of the > >symbol namespaces. These are all good points that you addressed! > > Agreed, thanks Masahiro for fixing up all the rough edges! Your series > of fixes look good to me, I will queue this up on modules-next this > week with the exception of patch 4 - Matthias, you are planning to > submit a patch that would supercede patch 04/07, right? > > Thanks! I missed to fix one issue in v1. sym_add_exported() misses to set s->namespace if the struct symbol is already created by read_dump() or sym_update_crc(). So, I just sent v2. -- Best Regards Masahiro Yamada
