On Fri, Sep 27, 2019 at 06:35:56PM +0900, Masahiro Yamada wrote:
I was hit by some problems caused by the module namespace feature that was merged recently. At least, the breakage of external module builds is a fatal one. I just took a look at the code closer, and I noticed some more issues and improvements. I hope these patches are mostly OK. The 4th patch might have room for argument since it is a trade-off of "cleaner implermentation" vs "code size".
Thanks Masahiro for taking the time to improve the implementation of the symbol namespaces. These are all good points that you addressed! For [04/07], I can work on this if you do not mind. Cheers, Matthias
Masahiro Yamada (7): modpost: fix broken sym->namespace for external module builds module: swap the order of symbol.namespace module: rename __kstrtab_ns_* to __kstrtabns_* to avoid symbol conflict module: avoid code duplication in include/linux/export.h kbuild: fix build error of 'make nsdeps' in clean tree nsdeps: fix hashbang of scripts/nsdeps nsdeps: make generated patches independent of locale Makefile | 2 +- include/linux/export.h | 104 ++++++++++++++--------------------------- kernel/module.c | 2 +- scripts/mod/modpost.c | 20 ++++---- scripts/nsdeps | 4 +- 5 files changed, 47 insertions(+), 85 deletions(-) -- 2.17.1
