Hi Matthias, On Fri, Sep 27, 2019 at 10:41 PM Matthias Maennich <maennich@xxxxxxxxxx> wrote: > > On Fri, Sep 27, 2019 at 06:35:56PM +0900, Masahiro Yamada wrote: > > > >I was hit by some problems caused by the module namespace feature > >that was merged recently. At least, the breakage of > >external module builds is a fatal one. I just took a look at the code > >closer, and I noticed some more issues and improvements. > > > >I hope these patches are mostly OK. > >The 4th patch might have room for argument since it is a trade-off > >of "cleaner implermentation" vs "code size". > > > Thanks Masahiro for taking the time to improve the implementation of the > symbol namespaces. These are all good points that you addressed! > > For [04/07], I can work on this if you do not mind. Please feel free to. Thanks for your review. -- Best Regards Masahiro Yamada
