On Wed, Sep 4, 2019 at 6:58 PM Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote: > > On Wed, Sep 4, 2019 at 10:07 AM Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote: > > > > On Wed, Sep 4, 2019 at 8:58 AM Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote: > > > > > > On Tue, Sep 3, 2019 at 11:50 PM Nick Desaulniers > > > <ndesaulniers@xxxxxxxxxx> wrote: > > > > > > > > On Sat, Aug 31, 2019 at 9:26 AM Masahiro Yamada > > > > <yamada.masahiro@xxxxxxxxxxxxx> wrote: > > > > > > > > > > KBUILD_ENABLE_EXTRA_GCC_CHECKS started as a switch to add extra warning > > > > > options for GCC, but now it is a historical misnomer since we use it > > > > > also for Clang, DTC, and even kernel-doc. > > > > > > > > Thanks for the patch! > > > > Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > > > > > > > > > Thanks for the patch. > > > I like the backward compatibility and am OK with pointing to 'make > > > --help' for the documentation part (KISS - Keep It Simple and > > > Short/Stupid). > > > > > > Reviewed-by: Sedat Dilek <sedat.dilek@xxxxxxxxx> > > > > If you will do a next version... > > > > - @echo ' make W=n [targets] Enable extra gcc checks, n=1,2,3 where' > > + @echo ' make W=n [targets] Enable extra checks, n=1,2,3 where' > > > > ...clarify on extra checks for compiler... > > > > + @echo ' make W=n [targets] Enable extra *compiler* checks, n=1,2,3 where' > > > > +KBUILD_EXTRA_WARN > +----------------- > +Specify the extra build checks. The same value can be assigned by passing > +W=... from the command line. > > For consistency reasons might be better: > > - @echo ' make W=n [targets] Enable extra gcc checks, n=1,2,3 where' > + @echo ' make W=n [targets] Enable extra build checks, n=1,2,3 where' > OK, I will squash this. Thanks. -- Best Regards Masahiro Yamada
