On Tue, 07 May 2019, Masahiro Yamada wrote: > These files do not define (USBHS_)DRIVER_NAME. Yet, they can be > successfully compiled because they are never built as a module by > anyone, i.e, the MODULE_ALIAS() calls are always no-op. > > A problem showed up when a patch "moduleparam: Save information about > built-in modules in separate file" is applied. With this new feature, > MODULE_*() are populated even if the callers are built-in. > > To avoid the build errors, the lines referencing to the undefined > macro must be removed. > > The complete fix is to remove all MODULE_* and #include <linux/module.h> > like many "make ... explicitly non-modular" commits did. > > For now, I am touching the offending lines. > > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > --- > > I will insert this commit before > "moduleparam: Save information about built-in modules in separate file" > > > arch/arm/plat-omap/dma.c | 1 - > drivers/clocksource/timer-ti-dm.c | 1 - > drivers/mfd/omap-usb-tll.c | 1 - For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx> -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
