* Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> [190506 17:40]: > On 06/05/2019 19:28, Masahiro Yamada wrote: > > These files do not define (USBHS_)DRIVER_NAME. Yet, they can be > > successfully compiled because they are never built as a module by > > anyone, i.e, the MODULE_ALIAS() calls are always no-op. > > > > A problem showed up when a patch "moduleparam: Save information about > > built-in modules in separate file" is applied. With this new feature, > > MODULE_*() are populated even if the callers are built-in. > > > > To avoid the build errors, the lines referencing to the undefined > > macro must be removed. > > > > The complete fix is to remove all MODULE_* and #include <linux/module.h> > > like many "make ... explicitly non-modular" commits did. > > > > For now, I am touching the offending lines. > > > > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > > --- > > Acked-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> Thanks, please feel free to merge together with your series: Acked-by: Tony Lindgren <tony@xxxxxxxxxxx> Or if you want me to queue it separately, please let me know. Regards, Tony
