On Thu, Nov 15, 2018 at 9:56 AM Paul Walmsley <paul.walmsley@xxxxxxxxxx> wrote:
>
> Drop modpost command line switches that are no longer used by
> makefile.modpost, upon request from Sam Ravnborg <sam@xxxxxxxxxxxx>,
> who wrote:
>
> modpost is not supposed to be used outside the kernel build. [...]
> I checked if there were any options supported by modpost that
> was not configurable in makefile.modpost.
> And I could see that the -M and -K options in getopt() was leftovers.
> The code that used these option was was dropped in:
> commit a8773769d1a1 ("Kbuild: clear marker out of modpost")
>
> Could you add a patch that delete these on top of what you already have.
>
> https://lore.kernel.org/lkml/20181020140835.GA3351@xxxxxxxxxxxx/
>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> Cc: Michal Marek <michal.lkml@xxxxxxxxxxx>
> Cc: linux-kbuild@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> Signed-off-by: Paul Walmsley <paul@xxxxxxxxx>
> ---
Applied to linux-kbuild.
Thanks!
> scripts/mod/modpost.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 0d998c54564d..85bd93c63180 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -2416,7 +2416,7 @@ int main(int argc, char **argv)
> struct ext_sym_list *extsym_iter;
> struct ext_sym_list *extsym_start = NULL;
>
> - while ((opt = getopt(argc, argv, "i:I:e:mnsST:o:awM:K:E")) != -1) {
> + while ((opt = getopt(argc, argv, "i:I:e:mnsST:o:awE")) != -1) {
> switch (opt) {
> case 'i':
> kernel_read = optarg;
> --
> 2.19.1
>
--
Best Regards
Masahiro Yamada
