On Fri, Apr 06, 2018 at 04:29:53PM +0900, Masahiro Yamada wrote: > 2018-04-06 0:03 GMT+09:00 Don Zickus <dzickus@xxxxxxxxxx>: > > On Thu, Apr 05, 2018 at 11:29:11AM +0900, Masahiro Yamada wrote: > >> 2018-04-05 4:56 GMT+09:00 Don Zickus <dzickus@xxxxxxxxxx>: > >> > We at Red Hat/Fedora have generally tried to have a per file breakdown of > >> > every config option we set. This makes it easy for us to add new options > >> > when they are exposed and keep a changelog of why they were set. > >> > > >> > A Fedora example is here: > >> > https://src.fedoraproject.org/cgit/rpms/kernel.git/tree/configs/fedora/generic > >> > > >> > Using various merge scripts, we build up a config file and run it through > >> > 'make listnewconfig' and 'make oldnoconfig'. The idea is to print out new > >> > config options that haven't been manually set and use the default until > >> > a patch is posted to set it properly. > >> > > >> > To speed things up, it would be nice to make it easier to generate a > >> > patch to post the default setting. The output of 'make listnewconfig' > >> > has two issues that limit us: > >> > > >> > - it doesn't provide the default value > >> > - it doesn't provide the new 'choice' options that get flagged in > >> > 'oldconfig' > >> > >> > >> So, 'listnewconfig' is a subset of 'listnewdefconfig'. > >> > >> I wonder if we could extend 'listnewconfig' to meet your demands > >> instead of adding the new target. > > > > Sure. I am open to whatever you think is appropriate. :-) > > > I prefer extending the existing target. Ok. So, you want me to respin with my additions added to listnewconfig, right? Easy enough. > > > > > >> > >> > >> What for '#choice' comment ? > > > > This was something silly added by me to make it obvious that > > CONFIG_KERNEL_XZ doesn't needed to be decided, it just needs us to re-review > > our current default to see if we should keep it or switch to something new. > > > > We can drop that piece of the patch. I wasn't sure if that separating > > 'choices' from 'configs|menuconfigs' is interesting or not. > > > I think it is better to drop '#choice'. Sure. No problem. :-) Cheers, Don -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
