Re: [PATCH] kconfig: add support for new option 'listnewdefconfig'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2018-04-05 4:56 GMT+09:00 Don Zickus <dzickus@xxxxxxxxxx>:
> We at Red Hat/Fedora have generally tried to have a per file breakdown of
> every config option we set.  This makes it easy for us to add new options
> when they are exposed and keep a changelog of why they were set.
>
> A Fedora example is here:
>   https://src.fedoraproject.org/cgit/rpms/kernel.git/tree/configs/fedora/generic
>
> Using various merge scripts, we build up a config file and run it through
> 'make listnewconfig' and 'make oldnoconfig'.   The idea is to print out new
> config options that haven't been manually set and use the default until
> a patch is posted to set it properly.
>
> To speed things up, it would be nice to make it easier to generate a
> patch to post the default setting.  The output of 'make listnewconfig'
> has two issues that limit us:
>
> - it doesn't provide the default value
> - it doesn't provide the new 'choice' options that get flagged in
>   'oldconfig'


So, 'listnewconfig' is a subset of 'listnewdefconfig'.

I wonder if we could extend 'listnewconfig' to meet your demands
instead of adding the new target.

I do not know why the current listnewconfig skips choice values.

(Anybody who relies on the current format of listnewconfig?)


Looks like the current listnewconfig
(it was 'nonint_oldconfig' before renaming)
was contributed from Fedora/RedHat side.


commit f0778c8c41001783d4074e34efc7d3e632d87ee3
Author: Aristeu Rozanski <aris@xxxxxxxxxx>
Date:   Thu May 6 12:48:34 2010 -0400

    kconfig: introduce nonint_oldconfig and loose_nonint_oldconfig

    This patch has been around for a long time in Fedora and Red Hat Enterprise
    Linux kernels and it may be useful for others. The nonint_oldconfig target
    will fail and print the unset config options while
loose_nonint_oldconfig will
    simply let the config option unset. They're useful in distro kernel packages
    where the config files are built using a combination of smaller
config files.

    Arjan van de Ven wrote the initial nonint_config and Roland
McGrath added the
    loose_nonint_oldconfig.

    Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxx> [defunct email]
    Whatevered-by: Kyle McMartin <kyle@xxxxxxxxxx>
    Acked-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
    Acked-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
    Signed-off-by: Aristeu Rozanski <aris@xxxxxxxxxx>
    [mmarek: whitespace fixes]
    Signed-off-by: Michal Marek <mmarek@xxxxxxx>




> This patch adds a new command 'listnewdefconfig' that does exactly
> what 'listnewconfig' does but addresses the above two issues too.
>
> This allows us to run a script
>
> make listnewdefconfig | rhconfig-tool -o patches; git send-email patches/
>
> The output of 'make listnewconfig':
>
> CONFIG_NET_EMATCH_IPT
> CONFIG_IPVLAN
> CONFIG_ICE
> CONFIG_NET_VENDOR_NI
> CONFIG_IEEE802154_MCR20A
> CONFIG_IR_IMON_DECODER
> CONFIG_IR_IMON_RAW
>
> The output of 'make listnewdefconfig':
>
> CONFIG_KERNEL_XZ=n #choice
> CONFIG_KERNEL_LZO=n #choice


What for '#choice' comment ?


> CONFIG_NET_EMATCH_IPT=n
> CONFIG_IPVLAN=n
> CONFIG_ICE=n
> CONFIG_NET_VENDOR_NI=y
> CONFIG_IEEE802154_MCR20A=n
> CONFIG_IR_IMON_DECODER=n
> CONFIG_IR_IMON_RAW=n
>
> Signed-off-by: Don Zickus <dzickus@xxxxxxxxxx>
> ---
-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux