On 2016-12-01 19:13, Peter Foley wrote: > On Tue, Nov 29, 2016 at 6:22 AM, Michal Marek <mmarek@xxxxxxxx> wrote: >> Dne 28.11.2016 v 07:44 Peter Foley napsal(a): >> This adds new -Wno-* options also for the gcc case, is there a reason >> for this? Also, the -Wno-missing-field-initializers option is not >> available in some old gccs, so we would need a HOSTCC equivalent of >> cc-disable-warning. >> >> Michal > > It appeared that the conditional was simply reversed, as > -fno-delete-null-pointer-checks is only supported by gcc, and > explicitly not supported by clang. > (see https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Makefile?id=61163efae02040f66a95c8ed17f4407951ba58fa) > It could be that the fno-delete-null-pointer-checks option was simply > misplaced, and the Wno-options should still be guarded by if(clang), > would that be a better approach? I think so. The -Wno-* options had not been present before clang support was added. It really looks like the -fno-delete-null-pointer-checks should not be there. Added Behan to CC. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
