On 06/18/14 06:14, J. Bruce Fields wrote: > On Wed, Jun 18, 2014 at 02:33:22PM +0200, Michal Marek wrote: >> Dne 18.6.2014 14:20, J. Bruce Fields napsal(a): >>> On Wed, Jun 18, 2014 at 11:06:12AM +0200, Michal Marek wrote: >>>> Dne 18.6.2014 00:38, J. Bruce Fields napsal(a): >>>>> The changelog there says >>>>> >>>>> The main Makefile sets its working directory to the object tree >>>>> and never changes it again. Therefore, we can use '.' instead of >>>>> the absolute path. >>>>> >>>>> But the main Makefile also exports objtree, and a quick grep suggests >>>>> lots of other uses outside the main Makefile. >>>> >>>> Do you have examples? Besides your report, I'm only aware of make >>>> deb-pkg and make *docs. What else? >>> >>> I haven't looked. >>> >>> I only note that grep finds 47 files referencing that variable, and >>> absent some argument that the remaining ones are correct, I'd be >>> inclined to revert. >> >> Do these 47 files change the working directory before referencing the >> variable? > > Sorry, I'm not volunteering to check. > > Note also that other variables are defined in terms of objtree, and they > may be exported or passed to other scripts. I'll note one side effect that I really dislike: If not in silent mode, scripts/mkmakefile tells me that the it is generating ./Makefile. I want to see the real path there instead of '.'. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
