On Wed, Jun 18, 2014 at 11:06:12AM +0200, Michal Marek wrote:
> Dne 18.6.2014 00:38, J. Bruce Fields napsal(a):
> > The scripts I use for my kernel testing rely on the targz-pkg make
> > target. After updating to 3.16-rc1 my scripts started failing. In
> > scripts/package/buildtar:
> >
> > tmpdir="${objtree}/tar-install"
> > tarball="${objtree}/linux-${KERNELRELEASE}-${ARCH}.tar"
> > ..
> > #
> > # Create the tarball
> > #
> > (
> > cd "${tmpdir}"
> > opts=
> > if tar --owner=root --group=root --help >/dev/null 2>&1; then
> > opts="--owner=root --group=root"
> > fi
> > tar cf - boot/* lib/* $opts | ${compress} > "${tarball}${file_ext}"
> > )
>
> Thanks for the report, I'll fix it.
Thanks!
> > The changelog there says
> >
> > The main Makefile sets its working directory to the object tree
> > and never changes it again. Therefore, we can use '.' instead of
> > the absolute path.
> >
> > But the main Makefile also exports objtree, and a quick grep suggests
> > lots of other uses outside the main Makefile.
>
> Do you have examples? Besides your report, I'm only aware of make
> deb-pkg and make *docs. What else?
I haven't looked.
I only note that grep finds 47 files referencing that variable, and
absent some argument that the remaining ones are correct, I'd be
inclined to revert. But I don't know if there's other work that now
depends on the change.
In any case, your call.
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
