On 6.9.2013 11:47, Yann E. MORIN wrote: > Michal, All, > > On 2013-09-05 11:38 +0200, Michal Marek spake thusly: >> On 3.9.2013 23:04, Yann E. MORIN wrote: >>> From: "Yann E. MORIN" <yann.morin.1998@xxxxxxx> >>> >>> Currently, the 'MODULES' symbol is hard-coded to be the default symbol >>> that enables/disables tristates, if no other symbol was declared with >>> 'option modules'. >>> >>> While this used to be needed for the Linux kernel, we now have an >>> explicit 'option modules' attached to the 'MODULES' symbol (since >>> cset 11097a036), so we no longer need to special-case it in the >>> kconfig code. >>> >>> Furthermore, kconfig is extensively used out of the Linux kernel, and >>> other projects may have another meaning for a symbol named 'MODULES'. >>> >>> This patch changes the way we enable/disable tristates: if a symbol was >>> found with 'option modules' attached to it, then that symbol controls >>> enabling tristates. Otherwise, tristates are disabled, even if a symbol >>> named 'MODULES' exists. >> >> Wasn't this change supposed to fix allmodconfig with KCONFIG_ALLCONFIG >> (http://lkml.org/lkml/2013/8/8/573)? Or is there still more to do? > > This is part of the fix, and there are still things to change, yes. > > I'm not done with it yet, since I was unavailable for some time, and I > just wanted this part to be reviewed/upstreamed before continuing, just > in case I was going the wrong way. Understood. I will merge this series now and send the whole branch to Linus later. > I'll be further working on this, and hope to have something at the > beginning of next week. OK, thanks! Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
