On 3.9.2013 23:04, Yann E. MORIN wrote: > From: "Yann E. MORIN" <yann.morin.1998@xxxxxxx> > > Currently, the 'MODULES' symbol is hard-coded to be the default symbol > that enables/disables tristates, if no other symbol was declared with > 'option modules'. > > While this used to be needed for the Linux kernel, we now have an > explicit 'option modules' attached to the 'MODULES' symbol (since > cset 11097a036), so we no longer need to special-case it in the > kconfig code. > > Furthermore, kconfig is extensively used out of the Linux kernel, and > other projects may have another meaning for a symbol named 'MODULES'. > > This patch changes the way we enable/disable tristates: if a symbol was > found with 'option modules' attached to it, then that symbol controls > enabling tristates. Otherwise, tristates are disabled, even if a symbol > named 'MODULES' exists. Wasn't this change supposed to fix allmodconfig with KCONFIG_ALLCONFIG (http://lkml.org/lkml/2013/8/8/573)? Or is there still more to do? Because I'm still getting: $ touch empty $ make KCONFIG_ALLCONFIG=empty allmodconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o SHIPPED scripts/kconfig/zconf.tab.c SHIPPED scripts/kconfig/zconf.lex.c SHIPPED scripts/kconfig/zconf.hash.c HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf scripts/kconfig/conf --allmodconfig Kconfig # # configuration written to .config # $ grep MODULES .config CONFIG_MODULES_USE_ELF_RELA=y # CONFIG_MODULES is not set $ Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
