On Mon, 29 Apr 2013, Steven Rostedt wrote:
> Can you add this patch and see if it fixes your issue. If so, can I add
> your "tested-by" to this patch?
>
> Thanks,
>
> -- Steve
>
> diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
> index 3368939..4606cdf 100644
> --- a/scripts/kconfig/streamline_config.pl
> +++ b/scripts/kconfig/streamline_config.pl
> @@ -156,7 +156,6 @@ sub read_kconfig {
>
> my $state = "NONE";
> my $config;
> - my @kconfigs;
>
> my $cont = 0;
> my $line;
> @@ -190,7 +189,13 @@ sub read_kconfig {
>
> # collect any Kconfig sources
> if (/^source\s*"(.*)"/) {
> - $kconfigs[$#kconfigs+1] = $1;
> + my $kconfig = $1;
> + # prevent reading twice.
> + if (!defined($read_kconfigs{$kconfig})) {
> + $read_kconfigs{$kconfig} = 1;
> + read_kconfig($kconfig);
> + }
> + next;
> }
>
> # configs found
> @@ -250,14 +255,6 @@ sub read_kconfig {
> }
> }
> close($kinfile);
> -
> - # read in any configs that were found.
> - foreach my $kconfig (@kconfigs) {
> - if (!defined($read_kconfigs{$kconfig})) {
> - $read_kconfigs{$kconfig} = 1;
> - read_kconfig($kconfig);
> - }
> - }
> }
>
> if ($kconfig) {
>
i'm interested -- should that Kconfig file have been written using a
different structure to avoid this issue? surely there are other
Kconfig files that would have had the same problem, no? i can't
believe this could be restricted to a single example involving
atheros stuff.
rday
p.s. i'm going to submit at least one patch to reorg the atheros
Kconfig file since it's a bit awkward at the moment -- when you select
some options, other options suddenly appear in arbitrary other
locations. i really hate that.
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
