On Monday 22 April 2013 14:00:46 Yann E. MORIN wrote: > On Mon, Apr 22, 2013 at 12:51:53PM -0400, Mike Frysinger wrote: > > the current EXPERT menuconfig is broken by some new options that happen > > to be sprinkled into the wrong place. seems like if a node is > > unprintable, it should get skipped for menuconfig purposes ? otherwise, > > this is a constantly losing battle where someone inserts new Kconfig > > options and forgets this nuance, and then it stays broken for a while > > until someone notices. this particular bug wrt EXPERT has been > > linux-3.2. > > > > for example, in the General setup section, you currently see: > > [ ] Configure standard kernel features (expert users) ---> > > [ ] Embedded system > > > > if you enable EXPERT there, the options get dumped into the same level > > instead > > > > of being under that menuconfig: > > [*] Configure standard kernel features (expert users) ---> > > [ ] Sysctl syscall support > > [*] Load all symbols for debugging/ksymoops > > ... > > [ ] Embedded system > > Yes, this is indeed disturbing. > > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@xxxxxxx> > > > is this feasible in the kconfig code ? > > From Documentation/kbuild/kconfig-language.txt: when i said "kconfig code", i was referring to making changes to the parsing source, not the kconfig language. > As far as I remember, this has always been the behaviour of menuconfig. > > What do you suggest the frontends do in this case, short of re-ordering > the options (which I think is not correct) ? i think you missed a critical part of my proposal: seems like *if a node is unprintable*, it should get skipped for menuconfig purposes to modify your example, i'm proposing a change for: menuconfig MENU_A bool "A" config OPT_B bool config OPT_C bool "C" depends on MENU_A OPT_B is not shown to the user (there is no option text), therefore it should automatically get skipped when searching for options to collapse into the menuconfig MENU_A. i do agree that if OPT_B had text, then the existing behavior would be unchanged. -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
