On 2013-03-03 21:23 +0100, Yann E. MORIN wrote:
> On Thursday 28 February 2013 Sven Joachim wrote:
>> On 2013-02-28 10:59 +0100, jlec@xxxxxxxxxx wrote:
>
>> > scripts/kconfig/Makefile | 4 +++-
>> > 1 file changed, 3 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
>> > index 3091794..c372976 100644
>> > --- a/scripts/kconfig/Makefile
>> > +++ b/scripts/kconfig/Makefile
>> > @@ -216,7 +216,9 @@ HOSTCFLAGS_gconf.o = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \
>> >
>> > HOSTLOADLIBES_mconf = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC))
>> >
>> > -HOSTLOADLIBES_nconf = -lmenu -lpanel -lncurses
>> > +HOSTLOADLIBES_nconf = -lmenu -lpanel
>> > +HOSTLOADLIBES_nconf += $(shell ncursesw5-config --libs 2>/dev/null \
>> > + || ncurses5-config --libs 2>/dev/null )
>>
>> This will link with ncursesw, not ncurses. Probably not what you want,
>> since nconf.h does not #include the right headers for that.
>>
>> On Debian/Ubuntu, there's also the problem that ncursesw5-config exists
>> even if the libncursesw5-dev package is not installed, so this patch
>> makes the build fail in such cases.
>
> The same goes for ncurses5-config, which is provided by ncurses-bin, and
> so is present even if the devel package is not installed, and the build
> will break, too.
This is not the same: if libncurses5-dev is not installed, the build is
going to fail anyway, since there is no -lmenu or -lpanel then.
I second the proposal to try pkg-config and fall back to -lncurses, BTW.
Cheers,
Sven
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
