Sven, Justin, All,
Sorry for the delay...
On Thursday 28 February 2013 Sven Joachim wrote:
> On 2013-02-28 10:59 +0100, jlec@xxxxxxxxxx wrote:
>
> > Ncurses provides a config script (ncurses5-config) to assist finding ncurses.
> > This patch makes use of it to detect the necessary libs for linking of the
> > ncurses nconfig dialog.
>
> That script is not necessarily called ncurses5-config, it might also be
> called ncurses6-config is ncurses is configured for a different ABI
> (--enable-ext-colors, --enable-ext-mouse). Although I would suspect
> that any distribution who does that provides a compatibility symlink.
Cygwin does provide nurses{,w}{5,6}-config.
> > scripts/kconfig/Makefile | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> > index 3091794..c372976 100644
> > --- a/scripts/kconfig/Makefile
> > +++ b/scripts/kconfig/Makefile
> > @@ -216,7 +216,9 @@ HOSTCFLAGS_gconf.o = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \
> >
> > HOSTLOADLIBES_mconf = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC))
> >
> > -HOSTLOADLIBES_nconf = -lmenu -lpanel -lncurses
> > +HOSTLOADLIBES_nconf = -lmenu -lpanel
> > +HOSTLOADLIBES_nconf += $(shell ncursesw5-config --libs 2>/dev/null \
> > + || ncurses5-config --libs 2>/dev/null )
>
> This will link with ncursesw, not ncurses. Probably not what you want,
> since nconf.h does not #include the right headers for that.
>
> On Debian/Ubuntu, there's also the problem that ncursesw5-config exists
> even if the libncursesw5-dev package is not installed, so this patch
> makes the build fail in such cases.
The same goes for ncurses5-config, which is provided by ncurses-bin, and
so is present even if the devel package is not installed, and the build
will break, too.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
