On Thu, Sep 20, 2012 at 09:17:14AM +0100, Jan Beulich wrote: > >>> On 19.09.12 at 22:30, Mark Asselstine <mark.asselstine@xxxxxxxxxxxxx> wrote: > > Since make 3.80 doesn't support secondary expansion it uses a fallback > > rule to create firmware directories which is matched after primary > > expansion of the $(installed-fw) rule's prerequisite. Commit > > 6c7080a61fc7 [firmware: fix directory creation rule matching with make > > 3.82] changed the expression generated after primary expansion such > > that the fallback was not matched. Updating the fallback rule to match > > the new look primary expansion is not an option for various reasons. > > > > The trailing slash added here to $(INSTALL_FW_PATH)/. while defining > > installed-fw-dirs fixes builds with make 3.82 since this will provide > > a matching rule for $(INSTALL_FW_PATH)/$$(dir %) when % is in the base > > firmware directory (ie. $(dir %) gives './'). Versions of make prior > > to 3.82 will strip this trailing slash along with the one generated by > > $(dir %) when % is in the base firmware directory and as such continue > > to function as before. > > > > Signed-off-by: Mark Asselstine <mark.asselstine@xxxxxxxxxxxxx> > > Tested-by: Jan Beulich <jbeulich@xxxxxxxx> Applied to kbuild.git#rc-fixes, thanks. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
