Re: [PATCH] scripts/config: properly report and set string options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg, All,

On Monday 09 April 2012 17:30:06 Greg KH wrote:
> On Mon, Apr 09, 2012 at 02:49:10PM +0200, Yann E. MORIN wrote:
> > Currently, scripts/config removes the leading double-quote from
> > string options, but leaves the trailing double-quote.
> > 
> > Also, double-quotes in a string are escaped, but scripts/config
> > does not unescape those when printing
> > 
> > Finally, scripts/config does not escape double-quotes when setting
> > string options.
[--SNIP--]
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@xxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> 
> How does this fit the Documentation/stable_kernel_rules.txt

Sorry, I was not aware of this list... My bad...
I'll know for next time. Thanks!

> qualification for a patch to be added to the stable releases?

I believe it qualifies because:
  - it is rather trivial
  - it breaks the build for users that tweak the kernel configuration from
    an upper-layer (aka 'integrated') build-system, using this script which
    is bundled with the kernel in the first place.
  - I am a 'real people', and 'it bothers' me ;-)

OTOH, it does not qualify because:
  - there is no Tested-by:
  - I forgot to specify which version it should be applied to
  - obviously, this fix is not yet in Linus' tree

So, please drop from -stable.

If you think that the first item, above, warrants a -stable fix, then I'll
properly re-submit once the patch is in Linus' tree.

Michal, should I re-send an updated patch whithout the CC:stable?

Sorry for the noise.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux