On 3.12.2011 10:24, Cheng Renquan wrote: > The modules_install, firmware_install, all install commands > don't generate such hidden unused files under destination; > I think headers_install also should not to generate such .install > & ..install.cmd files; > Usually, we call "make headers_install INSTALL_HDR_PATH=/some/path" > expecting it install just the header files, not those dot files; > > The original "call if_changed" could generate ..install.cmd and > together with "touch .install" could make the 2nd time headers_install > quite faster but it's not meaningful here, because we usually only install once; I think it makes sense for any *_install target to run the whole install sequence. The slight problem is that headers_check has an explicit dependency on headers_install, so someone doing make headers_install && make headers_check might not like the change. > diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst > index a57f5bd..b3deff2 100644 > --- a/scripts/Makefile.headersinst > +++ b/scripts/Makefile.headersinst > @@ -54,8 +54,7 @@ quiet_cmd_install = INSTALL $(printdir) ($(words > $(all-files))\ > $(PERL) $< $(objtree)/$(obj) $(install) $(SRCARCH) $(objhdr-y); \ > for F in $(wrapper-files); do \ > echo "\#include <asm-generic/$$F>" > $(install)/$$F; \ > - done; \ > - touch $@ > + done If you are removing the .install marker, then please also remove any reference to it from the makefile. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
