On Sat, 2011-11-19 at 01:24 -0500, Arnaud Lacombe wrote: > Hi, > > On Thu, Nov 17, 2011 at 5:54 PM, john stultz <johnstul@xxxxxxxxxx> wrote: > > On Thu, 2011-11-17 at 17:44 -0500, Arnaud Lacombe wrote: > >> Hi, > >> > >> On Thu, Nov 17, 2011 at 4:58 PM, john stultz <johnstul@xxxxxxxxxx> wrote: > >> > Hey Andrew, > >> > I've tried sending this via Michal a few times, but haven't heard much > >> > back. So I wanted to check if you would consider merging it via your > >> > tree, or if you had any suggestions of who would be better to > >> > review/merge this. > >> > > >> One of the worry I would have is that the script is merging config > >> blindly, ie. there is no dependency checking done. I have some some > >> work-in-progress to help resolving this, but still lots of thought to > >> be implemented. > > > > So the script actually does warn you if a specified option is dropped > > due to missing dependencies or if the option is removed. So, I guess > > could you clarify your concern a bit more? > > > well, assuming the following Kconfig's snippet: > > choice > bool "choice" > config A > bool "A" > config B > bool "B" > endchoice > > and trying to merge: > > - `config1': > > CONFIG_A=y > > - `config2': > > Result in: > > % sh scripts/kconfig/merge_config.sh config1 config2 > Merging config1 > Merging config2 > scripts/kconfig/conf --alldefconfig Kconfig > ./.tmp.config.uMY8Z97l9T:2:warning: override: B changes choice state > # > # configuration written to .config > # > > % cat .config > # > # Automatically generated file; DO NOT EDIT. > # Linux Kernel Configuration > # > # CONFIG_A is not set > CONFIG_B=y > > so we still get the warning from the incantation of `alldefconfig', > but the one in the script is defeated. You can find the fix for this along with other recent changes from Darren and Arnaud in my git tree here: git://git.linaro.org/people/jstultz/linux.git dev/config-fragments Browse-able here: http://git.linaro.org/gitweb?p=people/jstultz/linux.git;a=shortlog;h=refs/heads/dev/config-fragments Let me know if you have any other thoughts or feedback! thanks -john -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
