On Thu, Oct 27, 2011 at 02:07:14PM +0200, Sasha Levin wrote: > This patch adds 'make kvmconfig' which allows to add KVM guest support > to a config file. > > This allows for easier testing of configurations under virtualized > environments. > > Cc: Ingo Molnar <mingo@xxxxxxx> > Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> > Cc: Michal Marek <mmarek@xxxxxxx> > Cc: Pekka Enberg <penberg@xxxxxxxxxxxxxx> > Cc: linux-kbuild@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Suggested-by: Ingo Molnar <mingo@xxxxxxx> > Signed-off-by: Sasha Levin <levinsasha928@xxxxxxxxx> Two points about the implmentation that I do not like... The kvmconfig is an x86 specific thing - so it does not belong in the scripts/kconfig/Makefile The *config namespace is general config targets. Suggestion: Move the implmentation to arch/x86/Makefile and name the target something that does not match the *config pattern. Suggestion: make kvmbootable To tell that this convert the current config to a kvmbootable config. And then add the target to the x86 specific help too. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
