Hi, On Sun, May 22, 2011 at 10:06 PM, Arnaud Lacombe <lacombar@xxxxxxxxx> wrote: > Hi, > > On Thu, May 5, 2011 at 10:18 AM, Michal Marek <mmarek@xxxxxxx> wrote: >> On Wed, May 04, 2011 at 10:03:16PM -0400, Arnaud Lacombe wrote: >>> Rename parser's files to make them follow the same convention as `kconfig'. >> >> This mail didn't reach the mailing list, probably for size reasons. I >> suggest you create the patch with the -M option, it will be a bit harder to >> apply, but people will be able to see it. >> > yup, will do. > >>> scripts/genksyms/lex.c_shipped | 2709 ------------------------------ >>> scripts/genksyms/lex.genksyms.c_shipped | 2709 ++++++++++++++++++++++++++++++ >>> scripts/genksyms/lex.l | 409 ----- >>> scripts/genksyms/parse.c_shipped | 2353 -------------------------- >>> scripts/genksyms/parse.h_shipped | 139 -- >>> scripts/genksyms/parse.y | 473 ------ >> >> Renaming lex.l is a good idea, lex.lex.c would look silly. But I would >> leave parse.y and keywords.gperf and only rename the _shipped files to >> match what the new rules do. The names are local to the directory, so >> there is no urgent need to change them >> (and the history is easier to view if there are fewer renames). >> actually, renaming both the parser and the lexer would have been needed if we want to keep using the -p option for bison and -P option for flex, ie. using zconfparse() instead of yyparse(). The rationale being that the rules use the filename to derive the prefix. Without rename, we end up with very silly function name ala "lexlex()" or "parseparse()". For now, I will just drop those two options, kconfig will need to be fix to reflect this. Unfortunately, there do not seem to be a less non-intrusive solution. If renaming, kconfig is fine, genksyms needs fixes; if not renaming, kconfig needs fixes, genksyms is fine... - Arnaud -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
