Re: [RFC 1/9] genksyms: rename parser files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, May 5, 2011 at 10:18 AM, Michal Marek <mmarek@xxxxxxx> wrote:
> On Wed, May 04, 2011 at 10:03:16PM -0400, Arnaud Lacombe wrote:
>> Rename parser's files to make them follow the same convention as `kconfig'.
>
> This mail didn't reach the mailing list, probably for size reasons. I
> suggest you create the patch with the -M option, it will be a bit harder to
> apply, but people will be able to see it.
>
yup, will do.

>>  scripts/genksyms/lex.c_shipped           | 2709 ------------------------------
>>  scripts/genksyms/lex.genksyms.c_shipped  | 2709 ++++++++++++++++++++++++++++++
>>  scripts/genksyms/lex.l                   |  409 -----
>>  scripts/genksyms/parse.c_shipped         | 2353 --------------------------
>>  scripts/genksyms/parse.h_shipped         |  139 --
>>  scripts/genksyms/parse.y                 |  473 ------
>
> Renaming lex.l is a good idea, lex.lex.c would look silly. But I would
> leave parse.y and keywords.gperf and only rename the _shipped files to
> match what the new rules do. The names are local to the directory, so
> there is no urgent need to change them
> (and the history is easier to view if there are fewer renames).
>
@$!# ... git-blame and git-log do not behave the same on renamed
file... That is, when ran on a renamed file, git-blame will show the
old blame, totally unaffected, while git-log will only display the
history of the new name. Of course, I only checked git-blame :)

 - Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux