Re: [PATCH v2] package: Makefile: fix perf target bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 12 May 2011 17:09:03 -0700, mfmooney wrote:

> From: matt mooney <mfm@xxxxxxxxxxxxx>
> 
> Specify --git-dir and --work-tree when building perf targets to allow
> out-of-tree builds using O=<build-dir>.
> 
> The cat command had to be changed to allow proper file name expansion of
> the files listed in MANIFEST.
> 
> Signed-off-by: matt mooney <mfm@xxxxxxxxxxxxx> ---
> Okay, so I decided to just go ahead and send this. It removes the
> --work-tree option from the git rev-parse command. I did test it the way
> you said, without --work-tree on either statement, but the git archive
> command fails in that case.
> 

Looks like `git rev-parse` only needs the data in .git to work fine,
so this patch looks good to me,

Reviewed-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>

BTW, I think you need to Cc Ingo and Peter for perf changes.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux