On Mon, 2010-12-20 at 15:10 +0000, Michal Marek wrote: > On Mon, Dec 06, 2010 at 02:27:49PM -0500, Arnaud Lacombe wrote: > > This is an attempt to simplify the expressing printed by kconfig when a > > symbol is selected but still has direct unmet dependency. > > > > First, the symbol reverse dependency is split in sub-expression. Then, > > each sub-expression is checked to ensure that it does not contains the > > unmet dependency. This removes all the false-positive symbols which > > already have the correct dependency. Finally, only the symbol doing the > > "select" is printed, instead of the full dependency tree. > > > > CC: Catalin Marinas <catalin.marinas@xxxxxxx> > > Signed-off-by: Arnaud Lacombe <lacombar@xxxxxxxxx> > > --- > > scripts/kconfig/expr.c | 35 ++++++++++++++++++++++++++++++++++- > > scripts/kconfig/lkc_proto.h | 2 +- > > scripts/kconfig/symbol.c | 6 +++++- > > 3 files changed, 40 insertions(+), 3 deletions(-) > > I applied this to kbuild-2.6.git#kconfig now. If someone encounters a > warning that hides the actual culprit due to this patch, we will have to > solve it somehow, but otherwise these simplified expressions are wanted > IMO. It indeed simplified some of the long expressions but the resulting expression looks slightly different. The original warning (I temporarily removed the ARM CPU_32v6K dependency on CPU_V7 to trigger it): warning: (CPU_V7 && !ARCH_OMAP2 || CPU_MMP2 && ARCH_MMP) selects CPU_32v6K which has unmet direct dependencies (CPU_V6) With this patch, I get: warning: (CPU_V7 && CPU_MMP2) selects CPU_32v6K which has unmet direct dependencies (CPU_V6) Shouldn't we have a '||' between CPU_V7 and CPU_MMP2 (or something else, comma)? BTW, unrelated to this patch, I noticed this warning from CPU_MMP2 which in general shouldn't happen: config CPU_32v6K bool depends on CPU_V6 config CPU_MMP2 bool select CPU_V6 select CPU_32v6K CPU_MMP2 selects both CPU_V6 and CPU_32v6K but we still get the warning form CPU_MMP2. Is there an easy way to solve this? -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
