Re: [PATCHv2] kconfig: simplify select-with-unmet-direct-dependency warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 06, 2010 at 02:27:49PM -0500, Arnaud Lacombe wrote:
> Hi,
> 
> This is an updated version of the patch I sent in mid-September to simplify the
> unmet dependency warnings.
> 
>  - Arnaud
> 
> ---
> 
> This is an attempt to simplify the expressing printed by kconfig when a
> symbol is selected but still has direct unmet dependency.
> 
> First, the symbol reverse dependency is split in sub-expression. Then,
> each sub-expression is checked to ensure that it does not contains the
> unmet dependency. This removes all the false-positive symbols which
> already have the correct dependency. Finally, only the symbol doing the
> "select" is printed, instead of the full dependency tree.
> 
> CC: Catalin Marinas <catalin.marinas@xxxxxxx>
> Signed-off-by: Arnaud Lacombe <lacombar@xxxxxxxxx>
> ---
>  scripts/kconfig/expr.c      |   35 ++++++++++++++++++++++++++++++++++-
>  scripts/kconfig/lkc_proto.h |    2 +-
>  scripts/kconfig/symbol.c    |    6 +++++-
>  3 files changed, 40 insertions(+), 3 deletions(-)

I applied this to kbuild-2.6.git#kconfig now. If someone encounters a
warning that hides the actual culprit due to this patch, we will have to
solve it somehow, but otherwise these simplified expressions are wanted
IMO.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux&nblp;USB Development]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite Secrets]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux