>>> On 09.12.10 at 17:07, Arnaud Lacombe <lacombar@xxxxxxxxx> wrote: > On Thu, Dec 9, 2010 at 10:58 AM, Arnaud Lacombe <lacombar@xxxxxxxxx> wrote: > [..] >> I'm not either a big fan of testing `menu->visibility' truth, it is an >> expression which should be expended by the proper expr_* accessor to >> have less things to fix later. >> > gniarf, forget about that paragraph, I'm not fully awaken :/ > > What I thought about was the case where the visible property would > explicitly default to 'y' in which case the expression will have to be > simplified/manipulated, in that case, menu_finalize() will be the > place to do that, so this come back to my first comment. I'm not sure in menu_finalize() you can properly/easily deal with multiple prompts associated with the same symbol under different menus. Anyway, the patch I proposed works (for me), and I'm hoping to get it in unless someone (you?) comes up with a better one. Not fixing the (presumably unintended) side effect of your earlier patch seems undesirable to me. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
