>>> On 09.12.10 at 16:58, Arnaud Lacombe <lacombar@xxxxxxxxx> wrote:
> On Thu, Dec 9, 2010 at 3:11 AM, Jan Beulich <JBeulich@xxxxxxxxxx> wrote:
>> --- 2.6.37-rc5/scripts/kconfig/menu.c
>> +++ 2.6.37-rc5-kconfig-propagate-visibility/scripts/kconfig/menu.c
>> @@ -140,6 +140,20 @@ struct property *menu_add_prop(enum prop
>> }
>> if (current_entry->prompt && current_entry != &rootmenu)
>> prop_warn(prop, "prompt redefined");
>> +
>> + /* Apply all upper menus' visibilities to actual prompts. */
>> + if(type == P_PROMPT) {
>> + struct menu *menu = current_entry;
>> +
>> + while ((menu = menu->parent) != NULL) {
>> + if (!menu->visibility)
>> + continue;
>> + prop->visible.expr
>> + = expr_alloc_and(prop->visible.expr,
>> + menu->visibility);
>> + }
>> + }
>> +
> Shouldn't this better to be done in menu_finalize() ?
I don't know, I just looked for a place where I could get it done
in a reasonably simple way.
> I'm not either a big fan of testing `menu->visibility' truth, it is an
> expression which should be expended by the proper expr_* accessor to
> have less things to fix later.
Not sure what you're telling me here? What accessor?
Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
