On 11/26/2024 8:02 PM, Paul Moore wrote: > On Tue, Nov 26, 2024 at 1:21 PM Casey Schaufler <casey@xxxxxxxxxxxxxxxx> wrote: >> The variable name "prop" is inadvertently used twice in >> ima_match_rules(), resulting in incorrect use of the local >> variable when the function parameter should have been. >> Rename the local variable and correct the use if the parameter. > /if/of/ > >> Signed-off-by: Casey Schaufler <casey@xxxxxxxxxxxxxxxx> >> Suggested-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx> >> Reviewed-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx> >> --- >> security/integrity/ima/ima_policy.c | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) > Aside from the typo above (which can be fixed during the merge) this > looks good to me. Based on the discussion in the previous revision it > looks like Roberto would prefer this go via the LSM tree, so I'm going > to merge this into lsm/stable-6.13 and send this up to Linus later > this week (or early next depending on how my holiday travels go); > additional testing is always welcome :) Thank you. > I'm also going to swap Roberto's reviewed-by tag for his ack which he > gave on the previous revision as this is touching IMA code. Works for me.
