On Wed Jun 5, 2024 at 10:33 AM EEST, Joe Hattori wrote: > Hi Jarkko, > > Thank you for your time and feedback on my previous patch. > > 1. Drop the hyphens. > - I have removed them from the commit message in the v2 patch below. > 2. Wouldn't it be memory corruption, and not a leak? > - The validation_count field not returning to 0 causes > acpi_tb_release_table() not being called, which means memory is not > being unmapped. Therefore, I assume it is a memory leak. > 3. Why would ACPICA return corrupted data in this case? > - It is mostly unlikely that it returns corrupted data, but it would > happen when the ACPI table is misconfigured by the firmware. Although > this event is rare, I thought it would still be nice to take care of > the error path. > > Please find the updated patch v2 attached to this email. Actually: no. And when you send a patch send them as separate entities and version them [1]. And I don't believe you because I don't live in a belief system. There is total zero evidence provided of anything. And even if this was the case you should then submit the bug fix to ACPICA itself, not here. Thus, NAK. Please don't waste everyones time by inventing imaginary problems. It would be way more productive to solve some actual problems. [1] https://www.kernel.org/doc/html/v6.9/process/submitting-patches.html BR, Jarkko
