On Fri May 31, 2024 at 5:10 AM EEST, Joe Hattori wrote: > In `crb_acpi_add()`, we call `acpi_get_table()` to retrieve the ACPI > table entry. `acpi_put_table()` is called on the error path to avoid a > memory leak, but the current implementation does not call > `acpi_put_table()` when the `length` field of `struct acpi_table_header` > is not valid, which leads to a memory leak. Although this memory leak > only occurrs when the firmware misconfigured the ACPI table, it would > still be nice to have this fix. 1. Drop the hyphens. 2. Wouldn't it be memory corruption, and not a leak? 3. Why would ACPICA return corrupted data in this case? BR, Jarkko