On Sat Apr 13, 2024 at 11:10 AM EEST, Krzysztof Kozlowski wrote: > On 13/04/2024 09:15, M. Haener wrote: > > From: Michael Haener <michael.haener@xxxxxxxxxxx> > > > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. > > A nit, subject: drop second/last, redundant "binding". The "dt-bindings" > prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > > > Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml b/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml > > index 3ab4434b7352..af7720dc4a12 100644 > > --- a/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml > > +++ b/Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml > > @@ -32,6 +32,7 @@ properties: > > - enum: > > - infineon,slb9673 > > - nuvoton,npct75x > > + - st,st33ktpm2xi2c > > I got only one patch, but if these are compatible, why do you need > second patch? Plus binding come before users. > > Please explain what are you doing in other patch. > > Best regards, > Krzysztof Thanks, I agree with the remarks. So holding for update. BR, Jarkko
