On 13/04/2024 12:18, Lukas Wunner wrote: > On Sat, Apr 13, 2024 at 10:10:49AM +0200, Krzysztof Kozlowski wrote: >> Please use subject prefixes matching the subsystem. You can get them for >> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory >> your patch is touching. > > To be fair, "dt-bindings: tpm: " is actually the only prefix used > so far for the file that's touched here: > > $ git log --oneline Documentation/devicetree/bindings/tpm/tcg,tpm-tis-i2c.yaml > 26c9d15 dt-bindings: tpm: Consolidate TCG TIS bindings Command should be run on the directory, but anyway you are right. So it's fine. > > Personally I don't think we need to differentiate between spi/i2c/mmio > bindings in the prefix, so the prefix used by Michael seems fine. > > >> A nit, subject: drop second/last, redundant "binding". The "dt-bindings" >> prefix is already stating that these are bindings. >> See also: >> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > Right, so maybe just: > > dt-bindings: tpm: Add st,st33ktpm2xi2c > > ? > > >> I got only one patch, but if these are compatible, why do you need >> second patch? Plus binding come before users. > > Right, the order of the patches needs to be reversed it seems. What is the second patch? Device is or is not compatible? Best regards, Krzysztof
