On Mon, Jan 15, 2024 at 09:17:41PM +0100, Arnd Bergmann wrote:
> > Il 13/01/24 19:06, Lukas Wunner ha scritto:
> > > Since commit 26c9d152ebf3 ("dt-bindings: tpm: Consolidate TCG TIS
> > > bindings"), several issues are reported by "make dtbs_check" for arm64
> > > devicetrees:
> > >
> > > The compatible property needs to contain the chip's name in addition to
> > > the generic "tcg,tpm_tis-spi" and the nodename needs to be "tpm@0"
> > > rather than "cr50@0":
> > >
> > > tpm@1: compatible: ['tcg,tpm_tis-spi'] is too short
> > > from schema $id: http://devicetree.org/schemas/tpm/tcg,tpm_tis-spi.yaml#
> > >
> > > cr50@0: $nodename:0: 'cr50@0' does not match '^tpm(@[0-9a-f]+)?$'
> > > from schema $id: http://devicetree.org/schemas/tpm/google,cr50.yaml#
> > >
> > > Fix these schema violations.
>
> However, I got some conflicts trying to apply them on
> top of v6.7, so maybe check that and resend.
This patch needs to be applied on top of the soc-dt-6.8 tag,
not v6.7, because there were changes in your v6.8 pull request
which introduce a new TPM DT node in:
arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi
and modify an existing TPM DT node in:
arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
So if I'd base this patch on top of v6.7, it would be missing
the fixes for these three devicetrees and I'd have to submit
a separate patch with them. Happy to do so if that's what
you want but basing on top of soc-dt-6.8 seemed more reasonable
to me as initial submission.
Thanks!
Lukas
