On Mon, Jan 15, 2024, at 09:41, AngeloGioacchino Del Regno wrote:
> Il 13/01/24 19:06, Lukas Wunner ha scritto:
>> Since commit 26c9d152ebf3 ("dt-bindings: tpm: Consolidate TCG TIS
>> bindings"), several issues are reported by "make dtbs_check" for arm64
>> devicetrees:
>>
>> The compatible property needs to contain the chip's name in addition to
>> the generic "tcg,tpm_tis-spi" and the nodename needs to be "tpm@0"
>> rather than "cr50@0":
>>
>> tpm@1: compatible: ['tcg,tpm_tis-spi'] is too short
>> from schema $id: http://devicetree.org/schemas/tpm/tcg,tpm_tis-spi.yaml#
>>
>> cr50@0: $nodename:0: 'cr50@0' does not match '^tpm(@[0-9a-f]+)?$'
>> from schema $id: http://devicetree.org/schemas/tpm/google,cr50.yaml#
>>
>> Fix these schema violations.
>>
>> phyGATE-Tauri uses an Infineon SLB9670:
>> https://lore.kernel.org/all/ab45c82485fa272f74adf560cbb58ee60cc42689.camel@xxxxxxxxx/
>>
>> Gateworks Venice uses an Atmel ATTPM20P:
>> https://trac.gateworks.com/wiki/tpm
>>
>> Signed-off-by: Lukas Wunner <lukas@xxxxxxxxx>
>
> For MediaTek:
> Reviewed-by: AngeloGioacchino Del Regno
> <angelogioacchino.delregno@xxxxxxxxxxxxx>
>
> ...but I think you should split this per-SoC.
>
> Anyway, if Arnd wants to take this patch directly I'm also totally fine
> with that.
I would prefer to apply the combined patches:
if you end up with a series of patches that all have
identical commit texts, it's better to combine them
as that gives a more readable git history.
However, I got some conflicts trying to apply them on
top of v6.7, so maybe check that and resend.
Arnd
