Re: [PATCH 0/3] tpm: Convert to platform remove callback returning void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2023-03-20 at 09:06 +0100, Uwe Kleine-König wrote:
> Hello,
> 
> this series adapts the platform drivers below drivers/char/tpm to use the
> .remove_new() callback. Compared to the traditional .remove() callback
> .remove_new() returns no value. This is a good thing because the driver core
> doesn't (and cannot) cope for errors during remove. The only effect of a
> non-zero return value in .remove() is that the driver core emits a warning. The
> device is removed anyhow and an early return from .remove() usually yields a
> resource leak.
> 
> The drivers converted here returned zero in their remove callback, to the
> transformation was easy.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (3):
>   tpm/tpm_ftpm_tee: Convert to platform remove callback returning void
>   tpm/tpm_tis: Convert to platform remove callback returning void
>   tpm/tpm_tis_synquacer: Convert to platform remove callback returning
>     void
> 
>  drivers/char/tpm/tpm_ftpm_tee.c      | 6 +++---
>  drivers/char/tpm/tpm_tis.c           | 6 ++----
>  drivers/char/tpm/tpm_tis_synquacer.c | 6 ++----
>  3 files changed, 7 insertions(+), 11 deletions(-)
> 
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6

I've applied these, thank you.

BR, Jarkko




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux