The test for the AMD fTPM problem, which just went in, actually uses the wrong function template for request_locality(). It's missing an argument so the build breaks: drivers/char/tpm/tpm-chip.c:568:8: error: too few arguments to function ‘tpm_request_locality’ ret = tpm_request_locality(chip); ^~~~~~~~~~~~~~~~~~~~ drivers/char/tpm/tpm-chip.c:43:12: note: declared here static int tpm_request_locality(struct tpm_chip *chip, int locality) ^~~~~~~~~~~~~~~~~~~~ Fix this by requesting zero locality. Signed-off-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> Fixes: f1324bbc4011 ("tpm: disable hwrng for fTPM on some AMD designs") --- diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c index c04d101c7779..fee061780468 100644 --- a/drivers/char/tpm/tpm-chip.c +++ b/drivers/char/tpm/tpm-chip.c @@ -565,7 +565,7 @@ static bool tpm_amd_is_rng_defective(struct tpm_chip *chip) if (!(chip->flags & TPM_CHIP_FLAG_TPM2)) return false; - ret = tpm_request_locality(chip); + ret = tpm_request_locality(chip, 0); if (ret) return false;