On Mon, Nov 28, 2022 at 8:46 PM Vlastimil Babka <vbabka@xxxxxxx> wrote:
>
> On 11/28/22 18:07, Jason A. Donenfeld wrote:
> > On Mon, Nov 28, 2022 at 6:04 PM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
> >> > >
> >> > > > Please describe the concurrency scenario in the commit message where the
> >> > > > race could happen, if it is hard to reproduce, and add an appropriate fixes
> >> > > > tag.
> >> > >
> >> > > I will describe my scenario in more detail in the next version.
> >> > > Regarding the "fixes" tag - I'm not too familiar with it, but looking
> >> > > at the kernel submission guide, "fixes" should be used either when
> >> > > there was a particular commit in the past which introduced the bug or
> >> > > if a patch fixes an already logged bug entry (so that one can paste
> >> > > URL). In my case both are not applicable, so please advise what
> >> > > exactly I should put after this tag?
> >> >
> >> > It is
> >> >
> >> > Fixed: <12 character prefix of the hash> ("short summary")
> >> >
> >> > It should point out to the commit, which introduced the issue/bug.
> >>
> >> Somebody just reported a bug to me in hwrng stuff, which I traced down
> >> to this lack of tpm_try_get_ops(), and then I coded up the exact same
> >> patch as Jan's here, saw it fixed the problem, and then realized it was
> >> already submitted in that exact form.
> >>
> >> Because of some recent hwrng changes, this bug will be triggered more
> >> often than it was before.
> >>
> >> So, even though Jan hasn't submitted a v+1, do you think you could take
> >> this 1/3 commit, fix up the commit message or whatever you need there,
> >> and get this in for 6.1-rc8? It's an important fix.
> >>
> >> Thanks,
> >> Jason
> >
> > And if it helps, here's some more metadata:
> >
> > Tested-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
> > Reported-by: Vlastimil Babka <vbabka@xxxxxxx>
>
> You can make that:
> Reported-and-tested-by: Vlastimil Babka <vbabka@xxxxxxx>
>
> > Link: https://lore.kernel.org/all/c5ba47ef-393f-1fba-30bd-1230d1b4b592@xxxxxxx/
> > Cc: stable@xxxxxxxxxxxxxxx
>
> Not an expert here but looks like a valid Fixes: would be
> Fixes: e891db1a18bf ("tpm: turn on TPM on suspend for TPM 1.x")
>
> The 6.1-rc1 commit 3b006c439d58d ("hwrng: core - start hwrng kthread also
> for untrusted sources") likely exposed the bug in my case, but it wouldn't
> be the real root cause. But it makes it prudent to get the fix to 6.1.
Since this thread went dormant, and we're already pretty close to the
end of the cycle, I'm going to resend this with the commit message
fixed, as Jarkko asked at the beginning of the month.
Jan can then send whatever needs fixing in 2/3 and 3/3 whenever he
gets around to it.
I'll keep the original authorship intact of course.
Jason
