On Thu, Nov 03, 2022 at 03:54:48PM +0100, Jan Dabros wrote: > Currently tpm transactions are executed unconditionally in > tpm_pm_suspend() function, what may lead to races with other tpm > accessors in the system. > > Add proper locking mechanisms by calling tpm_try_get_ops() which is a > wrapper on tpm_chip_start(). > > Signed-off-by: Jan Dabros <jsd@xxxxxxxxxxxx> AFAIK processes are freezed before suspend callbacks are called, and the callbacks are called sequentially. I have no idea what is meant by "TPM accessor" here. Please describe the concurrency scenario in the commit message where the race could happen, if it is hard to reproduce, and add an appropriate fixes tag. BR, Jarkko
