On Fri, Jun 10, 2022 at 03:29:12PM +0200, Morten Linderud wrote: > On Thu, Jun 09, 2022 at 02:47:12PM +0300, Jarkko Sakkinen wrote: > > On Thu, Jun 09, 2022 at 10:11:59AM +0200, Morten Linderud wrote: > > > On Thu, Jun 09, 2022 at 07:46:46AM +0300, Jarkko Sakkinen wrote: > > > > > > > What you are using this for? Without any actual bug report, this > > > > is an obvious NAK. > > > > > > I have hardware with faulty ACPI values which prevents me from getting a > > > eventlog. I can surely make a bugreport if it helps the case, but that seems > > > like an arbiterary hurdle when I have already spent the time tracking down the > > > issue and proposed a fix. > > > > What is the hardware? > > I included it in the commit message with the listed ACPI table values. > > > The following hardware was used to test this issue: > Framework Laptop (Pre-production) > BIOS: INSYDE Corp, Revision: 3.2 > TPM Device: NTC, Firmware Revision: 7.2 > > Dump of the faulty ACPI TPM2 table: > [000h 0000 4] Signature : "TPM2" [Trusted Platform Module hardware interface Table] > [004h 0004 4] Table Length : 0000004C > [008h 0008 1] Revision : 04 > [009h 0009 1] Checksum : 2B > [00Ah 0010 6] Oem ID : "INSYDE" > [010h 0016 8] Oem Table ID : "TGL-ULT" > [018h 0024 4] Oem Revision : 00000002 > [01Ch 0028 4] Asl Compiler ID : "ACPI" > [020h 0032 4] Asl Compiler Revision : 00040000 > > [024h 0036 2] Platform Class : 0000 > [026h 0038 2] Reserved : 0000 > [028h 0040 8] Control Address : 0000000000000000 > [030h 0048 4] Start Method : 06 [Memory Mapped I/O] > > [034h 0052 12] Method Parameters : 00 00 00 00 00 00 00 00 00 00 00 00 > [040h 0064 4] Minimum Log Length : 00010000 > [044h 0068 8] Log Address : 000000004053D000 > > -- > Morten Linderud > PGP: 9C02FF419FECBE16 If this is not something you can buy off-the-shelf, it unfortunately does not cut. BR, Jarkko