Re: [PATCH v3 8/9] tests: Extend sign_verify test with pkcs11-specific test

[Mimi Zohar <zohar@xxxxxxxxxxxxx>]

On Wed, 2021-09-08 at 15:23 -0400, Stefan Berger wrote:
> From: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> 
> Extend the sign_verify test with a pkcs11-specific test.
> 
> Since the openssl command line tool now needs to use a key provided by
> an engine, extend some command lines with the additional parameters
> '--keyform engine'. These parameters are passed using the global variable
> OPENSSL_KEYFORM, which is only set when pkcs11 URIs are used.
> 
> Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>

Thanks, Stefan.  Much easier to review as an independent patch.
> ---
>  tests/functions.sh     | 45 ++++++++++++++++++++++++++++++++++++
>  tests/sign_verify.test | 52 ++++++++++++++++++++++++++++++------------
>  2 files changed, 83 insertions(+), 14 deletions(-)
> 
> diff --git a/tests/functions.sh b/tests/functions.sh
> index 91cd5d9..dce278b 100755
> --- a/tests/functions.sh
> +++ b/tests/functions.sh
> @@ -272,3 +272,48 @@ _report_exit() {
>    fi
>  }
>  
> +# Cleanups when exiting
> +_at_exit() {
> +  _report_exit
> +  if [ -n "${WORKDIR}" ]; then
> +    rm -f "${WORKDIR}"
> +  fi
> +}

There's one caller of _report_exit().  I don't see a need to define a
new function.

thanks,

Mimi