On Wed, 2021-09-08 at 15:23 -0400, Stefan Berger wrote: > From: Stefan Berger <stefanb@xxxxxxxxxxxxx> Having a "From: " line normally occurs when the original author is being credited with the patch, but the patch is being updated/modified by someone else. > > This series of patches adds support for signing with pkcs11 URIs so that > pkcs11-enabled devices can also be used for file signing. > > A test program is provided setting up SoftHSM for test cases to use. I added > two test cases for testing with SoftHSM. The correlation between the first paragraph and the second is missing. The second paragraph also needs to be written in the 3rd person. Perhaps say something like, "Extend the existing sign_verify.test with tests for the new pkcs11 URI support. Use the SoftHSM, when available, as the pkcs11 device." thanks, Mimi
