> On Jul 6, 2021, at 5:34 AM, Mimi Zohar <zohar@xxxxxxxxxxxxx> wrote: > > On Mon, 2021-07-05 at 16:09 -0700, Hao Wu wrote: >>> On Jul 5, 2021, at 12:15 AM, Jarkko Sakkinen <jarkko@xxxxxxxxxx> wrote: >>> >> >>>> Signed-off-by: Hao Wu <hao.wu@xxxxxxxxxx> >>>> --- >>>> Test Plan: >>>> - Run fixed kernel with ATMEL TPM chips and see crash >>>> has been fixed. >>>> - Run fixed kernel with non-ATMEL TPM chips, and confirm >>>> the timeout has not been changed. >>> >>> The changelog is missing. >> Sorry, I don’t get your point here. Could you help clarify it a bit. >> I did follow the section 14, but I didn’t see anything specifically needed after `---` >> Could you be specific ? Thanks for your time. > > The changes from one version of a patch, or patch set, to the next has > moved around a bit. Some people put it in the cover letter, others put > it on the individual patches. It's also moved from within the patch > description to after the dashes. Documentation/process/submitting- > patches.rst provides an example, but leaves out the word "Changelog". > For an explanation of what goes into the patch description versus the > Changelog, search for "Other comments relevant only to the moment or > the maintainer". I see. That makes sense to me now. The term “changelog” appears multiple times In the doc for different purpose, thus it was confusing to me. Here we are referring to "patch changelog”. Will add it after `—`. Thanks for the clarification! > > For example, this version of the patch limits increasing the delay just > for Atmel TPM 1.2 chips. At minimum it would be included in the > Changelog, but more likely included in the patch description itself and > perhaps even in the Subject line. > > thanks, > > Mimi > >> >>> Please read section 14 of >>> >>> https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html >>> >>> /Jarkko >> Hao > > Hao
